Develop #8

Open
wazolab wants to merge 50 commits from develop into master
7 changed files with 31 additions and 36 deletions
Showing only changes of commit 2a1cf5ae8f - Show all commits

View File

@@ -14,33 +14,34 @@ You've been given the task of creating a simple application with create/read/del
- [x] Create a branch off of master, commit all your work to this new branch.
- [ ] When you are finished, open a PR to master (but do not merge it). In the PR description, copy, paste and answer the following:
```
---
### Your name
Noé Viricel
### What was challenging?
Cypress.io
### What did you enjoy doing?
...
### If you had more time, what would you improve/do differently?
#### Components Lazy-Loading
*(Prefetching auto-handled since Vue CLI 3+)*
- [x] Dynamic imports (works for most browsers).
- [ ] Improve browser support by using Async components, it would offer more control over Component's loading / error states.
- Use AntD (or any CSS Framework)
- CSS Module
- Form Validations
- Page Transitions
- Loading State
- Setup environment variables
- Setup API proxy with Axios
- More Accessibility
- Component Lazy Loading
- Image Caching & Lazy Loading
- Inject axios globally as $http
- More test
- [] Use AntD (or any CSS Framework)
- [] CSS Module
- [] Form Validations
- [] Page Transitions
- [] Loading State
- [] Setup environment variables
- [] Setup API proxy with Axios
- [] More Accessibility
- [] Image Caching & Lazy Loading
- [] Inject axios globally as $http
- [] More test
### How much time (more or less) it took you to complete the task?
@@ -49,7 +50,7 @@ You've been given the task of creating a simple application with create/read/del
### What do you think about the task itself? (Was it a good experience? If not why?)
### Summary in a gif
```
- [ ] Invite us to your repository: @chayaline, @emilyrosina, @adamwardecki, @dangzo, @thomas-lhuillier, @SavanovicN & @Sergeon
## The specification

View File

@@ -13,14 +13,13 @@
import { mapState } from "vuex";
import Footer from "@/components/Footer";
import Header from "@/components/Header";
import AddFruit from "@/components/AddFruit";
export default {
name: "App",
components: {
Footer,
Header,
AddFruit
AddFruit: () => import("@/components/AddFruit")
},
computed: {
...mapState(["modalIsOpen"])

View File

@@ -30,12 +30,11 @@
<script>
import { mapState } from "vuex";
import ImageSkeleton from "./ImageSkeleton";
export default {
name: "ImageUnsplash",
components: {
ImageSkeleton
ImageSkeleton: () => import("./ImageSkeleton")
},
props: {
containerClass: {

View File

@@ -15,13 +15,12 @@
<script>
import { mapState } from "vuex";
import GridItemSkeleton from "./GridItemSkeleton";
import GridItem from "./GridItem";
export default {
name: "Grid",
components: {
GridItemSkeleton,
GridItem
GridItem: () => import("./GridItem")
},
props: {
data: Array

View File

@@ -21,11 +21,10 @@
<script>
import { mapState } from "vuex";
import DeleteItem from "./DeleteItem";
export default {
name: "GridItem",
components: { DeleteItem },
components: { DeleteItem: () => import("./DeleteItem") },
props: {
item: Object
},

View File

@@ -26,11 +26,10 @@
<script>
import { mapState } from "vuex";
import DeleteItem from "@/components/Grid/DeleteItem";
export default {
name: "FruitDetails",
components: { DeleteItem },
components: { DeleteItem: () => import("@/components/Grid/DeleteItem") },
data() {
return {
modalOpen: true

View File

@@ -11,11 +11,10 @@
<script>
import { mapState } from "vuex";
import Grid from "@/components/Grid/Grid";
export default {
name: "Fruits",
components: { Grid },
components: { Grid: () => import("@/components/Grid/Grid") },
computed: {
...mapState(["fruits"])
},