Develop #8

Open
wazolab wants to merge 50 commits from develop into master
wazolab commented 2020-12-08 23:51:49 +00:00 (Migrated from github.com)

Feedbacks

Your name

Noé Viricel

What was challenging?

  • Cypress.io, as I never used it before, I started to learn the basis from their documentation. It looks very interesting in a product quality point of view, I never had the occasion to go that far in a product development process.
  • A bit tricky at first to choose which API data to keep.

What did you enjoy doing?

I appreciated the opportunity to imagine an app from a raw array of data. With no graphical support of any kind. It gave me the opportunity to truly showcase my creativity and skills on different subject.
I have taken the time to confirm knowledge and go further into testing data store (Vuex).

Spoiler: I admit that I tried to stick to your graphic environement

If you had more time, what would you improve/do differently?

  • Improve "Component's dynamic imports" browser support by using Async components, it would offer more control over Component's loading / error states.

  • Use CSS Framework (I'm fond of AntDesign and Tailwind CSS)

  • CSS Module as the app will grow, offering styles more modularity.

  • Vue.js Composition API on a larger app.

  • Form and Props validation.

  • Page Transitions

  • Better loading state management

  • Setup .env file for environnement isolation (dev / test / prod).

  • Work on CSS Accessibility

  • Caching & Lazy Loading

  • Inject axios globally (as $http)

  • Notification System (Errors, Infos, Warning, Success)

  • More unit test

  • Definitely more End-to-End test :)

  • and probably more ...

    How much time (more or less) it took you to complete the task?

    I've made this app in 5 days of code, more or less 25 hours ... (I did count commits timestamps 😩)

    What do you think about the task itself? (Was it a good experience? If not why?

    I believe it's a good exercise with enough constraints to let you express yourself (in a coder's mind I mean).
    I think that this task allows to approach each stage of a Frontent project conception.

    I rather be tested like that than with a bulk of logic tests (that I find arbitrary) as I am more in a situation to think and develop ideas.

Summary in a gif

feedback

## Feedbacks ### Your name Noé Viricel ### What was challenging? - Cypress.io, as I never used it before, I started to learn the basis from their documentation. It looks very interesting in a product quality point of view, I never had the occasion to go that far in a product development process. - A bit tricky at first to choose which API data to keep. ### What did you enjoy doing? I appreciated the opportunity to imagine an app from a raw array of data. With no graphical support of any kind. It gave me the opportunity to truly showcase my creativity and skills on different subject. I have taken the time to confirm knowledge and go further into testing data store (Vuex). *_**Spoiler:** I admit that I tried to stick to your graphic environement_* ### If you had more time, what would you improve/do differently? - Improve "Component's dynamic imports" browser support by using Async components, it would offer more control over Component's loading / error states. - Use CSS Framework (I'm fond of AntDesign and Tailwind CSS) - CSS Module as the app will grow, offering styles more modularity. - Vue.js Composition API on a larger app. - Form and Props validation. - Page Transitions - Better loading state management - Setup .env file for environnement isolation (dev / test / prod). - Work on CSS Accessibility - Caching & Lazy Loading - Inject axios globally (as $http) - Notification System (Errors, Infos, Warning, Success) - More unit test - Definitely more End-to-End test :) - and probably more ... ### How much time (more or less) it took you to complete the task? I've made this app in 5 days of code, more or less 25 hours ... (I did count commits timestamps :weary:) ### What do you think about the task itself? (Was it a good experience? If not why? I believe it's a good exercise with enough constraints to let you express yourself (in a coder's mind I mean). I think that this task allows to approach each stage of a Frontent project conception. *I rather be tested like that than with a bulk of logic tests (that I find arbitrary) as I am more in a situation to think and develop ideas.* <details> <summary>Summary in a gif</summary> ![feedback](https://user-images.githubusercontent.com/38253764/101555770-9535dc00-39b9-11eb-8b16-ede3d5a3de8e.gif) </details>
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin develop:develop
git checkout develop
Sign in to join this conversation.