diff --git a/README.md b/README.md index 0008996..e0a71d6 100644 --- a/README.md +++ b/README.md @@ -12,46 +12,55 @@ You've been given the task of creating a simple application with create/read/del - [x] Create a private repository on Github. - [x] Create a new Vue project using Vue-CLI within the new repository: you may use any preprocessors, testing frameworks, linting etc that you like. - [x] Create a branch off of master, commit all your work to this new branch. -- [ ] When you are finished, open a PR to master (but do not merge it). In the PR description, copy, paste and answer the following: +- [x] When you are finished, open a PR to master (but do not merge it). In the PR description, copy, paste and answer the following: --- +## Feedbacks + ### Your name NoƩ Viricel ### What was challenging? -Cypress.io +- Cypress.io, as I never used it before, I started to learn the basis from their documentation. It looks very interesting in a product quality point of view, I never had the occasion to go that far in a product development process. +- A bit tricky at first to choose which API data to keep. ### What did you enjoy doing? -... +I appreciated the opportunity to imagine an app from a raw array of data. With no graphical support of any kind. It gave me the opportunity to truly showcase my creativity and skills on different subject. +I have taken the time to confirm knowledge and go further into testing data store (Vuex). -### If you had more time, what would you improve/do differently? - #### Components Lazy-Loading - *(Prefetching auto-handled since Vue CLI 3+)* - - [x] Dynamic imports (works for most browsers). - - [ ] Improve browser support by using Async components, it would offer more control over Component's loading / error states. - +*_**Spoiler:** I admit that I tried to stick to your graphic environement_* + +### If you had more time, what would you improve/do differently? + - Improve "Component's dynamic imports" browser support by using Async components, it would offer more control over Component's loading / error states. + - Use CSS Framework (I'm fond of AntDesign and Tailwind CSS) + - CSS Module as the app will grow, offering styles more modularity. + - Vue.js Composition API on a larger app. + - Form and Props validation. + - Page Transitions + - Better loading state management + - Setup .env file for environnement isolation (dev / test / prod). + - Work on CSS Accessibility + - Caching & Lazy Loading + - Inject axios globally (as $http) + - Notification System (Errors, Infos, Warning, Success) + - More unit test + - Definitely more End-to-End test :) + - and probably more ... - - [] Use AntD (or any CSS Framework) - - [] CSS Module - - [] Form Validations - - [] Page Transitions - - [] Loading State - - [] Setup environment variables - - [] Setup API proxy with Axios - - [] More Accessibility - - [] Image Caching & Lazy Loading - - [] Inject axios globally as $http - - [] More test ### How much time (more or less) it took you to complete the task? - + I've made this app in 5 days of code, more or less 25 hours ... (I did count commits timestamps :weary:) - ### What do you think about the task itself? (Was it a good experience? If not why?) + ### What do you think about the task itself? (Was it a good experience? If not why? + I believe it's a good exercise with enough constraints to let you express yourself (in a coder's mind I mean). + I think that this task allows to approach each stage of a Frontent project conception. + + *I rather be tested like that than with a bulk of logic tests (that I find arbitrary) as I am more in a situation to think and develop ideas.* ### Summary in a gif -- [ ] Invite us to your repository: @chayaline, @emilyrosina, @adamwardecki, @dangzo, @thomas-lhuillier, @SavanovicN & @Sergeon +- [x] Invite us to your repository: @chayaline, @emilyrosina, @adamwardecki, @dangzo, @thomas-lhuillier, @SavanovicN & @Sergeon ## The specification diff --git a/feedback.gif b/feedback.gif new file mode 100644 index 0000000..14eae23 Binary files /dev/null and b/feedback.gif differ